Do not reuse PersistentContextPtr instances #261
Merged
+27
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 1.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
szegedi
force-pushed
the
szegedi/no-dead-list
branch
from
ee05b8d to
42bb2d4
Compare
szegedi
force-pushed
the
szegedi/no-dead-list
branch
from
42bb2d4 to
e9cd659
Compare
szegedi
force-pushed
the
szegedi/no-dead-list
branch
from
e9cd659 to
f1af6c9
Compare
BridgeAR
reviewed
Feb 9, 2026
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
While we can try this, I do not believe this is the actual cause of the report
|
@BridgeAR Actually I think it's good to remove Note: I see that |
IlyasShabi
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Removes caching/reuse of PersistentContextPtr instances.
Motivation:
This was always a speculative attempt to reduce native memory fragmentation. The standard library can be expected to do some of this itself, so we should not be doing this, especially since it is also removed in #255 and it seems to be causing issues (see #7355).
Additional Notes:
#255 also contains this, but we can roll it out as a quicker measure to try to eliminate the memory issue. An advantage of rolling this out separately is that #255 requires some changes in dd-trace-js too, while this as a standalone change does not.